That should be enough to fix the issue (not tested yet)

@jpinsonneau: This pull request references NETOBSERV-2244 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.

I don't get the logic But if that works, ok! :-) perhaps I just don't have enough of my morning coffee /lgtm (tests required)

The use case here is:

• user goes into topology
• set scope to network
• check "display empty"
• finally filter on an empty udn

Previously, the view was showing an empty message since the returned metrics are empty despite the show empty is still checked and empty udns are still provided
With this change, the view should keep showing the topology since empty items are available

Gonna test that today 😉

/retest

New image:
quay.io/netobserv/network-observability-console-plugin:9bc78ed

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9bc78ed make set-plugin-image

Tested and works fine:

The only downside of this approach is that the UI is going to show all the empty UDNs even when you filter on network names 🤔

I may add an exception for that case if you feel it's necessary but it could become hard to maintain in future if we implement the same "show empty" behavior on other scopes.
For now, the filtered resource(s) are highlighted in the view which is good enough to me.

WDYT ?

@jpinsonneau the "display empty" checkbox is enabled by default, right? I think that would be my concern, users who did not explicitly wanted to show empty items, they would still see them regardless of what they filter.
If that wasn't enabled by default, that wouldn't be a problem IMO because only user who purposely want to see empty items would be "affected"

@jpinsonneau the "display empty" checkbox is enabled by default, right? I think that would be my concern, users who did not explicitly wanted to show empty items, they would still see them regardless of what they filter. If that wasn't enabled by default, that wouldn't be a problem IMO because only user who purposely want to see empty items would be "affected"

Yes we can move if to false by default if you prefer.

/ok-to-test

Filtering on empty UDN now works, but shows all empty UDN's irrespective of whats being filtered.

+1 to Joel's comment. Its better to keep Show Empty unchecked on default and the above scenario only affects customers who wants to see empty UDN's

@jpinsonneau are we ok to implement the opposite default as mentioned?

@jpinsonneau are we ok to implement the opposite default as mentioned?

sure, done in d44a03e

You will need to clear your local storage to see the diff

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

/retest

thanks,
/lgtm

/ok-to-test

New image:
quay.io/netobserv/network-observability-console-plugin:1b712a9

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=1b712a9 make set-plugin-image

@jpinsonneau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Full PR test history. Your PR dashboard.

/label qe-approved

@jpinsonneau: This pull request references NETOBSERV-2244 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.20.0" version, but no target version was set.